-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
refactor: migrate from npm to pnpm #7645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: migrate from npm to pnpm #7645
Conversation
…deprecated preset
|
@Daniel-Mendes, thanks for the effort, but why would we want this? It's a huge changelog, so we need a good reason to merge this. |
|
Hi @martinjagodic, Thanks for the review! The large diff comes from running the official React codemod to migrate from jsx: "react" to jsx: "react-jsx". It automatically removed the now-unnecessary import React lines across many files. I agree it makes the history heavy. If you prefer, I can split this into two PRs:
That way, each change is easier to review. |
|
The main reason for switching to pnpm is maintainability, not just speed. Its strict dependency structure makes it easier to detect unused or obsolete packages, avoid hidden hoisting issues, and keep the dependency tree clean. It also ensures more reliable installs and simpler future migrations. |
|
Yes, please split into 2 PRs; these are 2 different things. I doubt that we will accept the pnpm migration. We can detect unused packages with npm just as well. Yes, it looks cleaner to only have a version in one place and then reference it in another, but these are managed automatically by npm (and nx), so it's not intended to be used by a human. The real issue here is that we have one package for every feature, which is the real cause of stress. The React codemod is a nice refactor. I would be glad to merge that. |
|
https://github.com/Daniel-Mendes/decap-cms/blob/refactor/migrate-to-vite/scripts/vite.js And what about a migration to vite for better dev and build times, i already have a test repo, do you want a pull request too ? |
|
If you have it already, it would be nice to see the Vite PR. But if it's a huge diff, I would be wary about merging it. |
|
So i splitted the jsx runtime to #7647 |
Summary
Migrate the repository to pnpm and standardize dependency management across the monorepo:
PS: I also fixed this open issue #7616
Test plan
I run
pnpm run buildand all packages build with no errorsChecklist
Please add a
xinside each checkbox: